Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24051 )
Change subject: KUDU-3743 Add table statistics to Python client ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/24051/1/python/kudu/tests/test_client.py@1277 PS1, Line 1277: def test_on_disk_size_is_valid(self): : stats = self.client.get_table_statistics(self.ex_table) : # -1 means unsupported; any non-negative value is also valid. : self.assertGreaterEqual(stats.on_disk_size, -1) : : def test_live_row_count_is_valid(self): : stats = self.client.get_table_statistics(self.ex_table) : self.assertGreaterEqual(stats.live_row_count, -1) Since test_live_row_count_reflects_written_data already assumes the test Kudu cluster supports live row count and disk size stats, would it make sense to make the comparison more strict, use the reference value of 0? -- To view, visit http://gerrit.cloudera.org:8080/24051 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7b36f62a4ef018e0e08e83ad04d451ca1c1dcd7 Gerrit-Change-Number: 24051 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2026 04:31:46 +0000 Gerrit-HasComments: Yes
