Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24121 )
Change subject: [metrics] Export hostname as a Prometheus label when entity labels are enabled ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/24121/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24121/3//COMMIT_MSG@14 PS3, Line 14: This patch adds a 'hostname' label to each metric, allowing the source : node to be identified without relying on Prometheus relabel_configs. Does it make sense to provide a flag to opt-out from always populating the 'hostname' label in case if there is need for specific re-labeling by a means of Prometheus itself (e.g., relabel_configs)? I guess it makes sense to have this on by default if having such a flag, though. -- To view, visit http://gerrit.cloudera.org:8080/24121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43b4c8ea5736e99c20b25a2ffea3c6c8dcb9d27e Gerrit-Change-Number: 24121 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Mon, 23 Mar 2026 19:22:04 +0000 Gerrit-HasComments: Yes
