Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24122 )
Change subject: KUDU-3755 tool: add leave_files to control shell ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24122/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/24122/1/src/kudu/tools/kudu-tool-test.cc@8662 PS1, Line 8662: ASSERT_EQ(0, exit_status); Does it make sense to add a scenario to be explicit on the behavior when exit status isn't 0? http://gerrit.cloudera.org:8080/#/c/24122/1/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: http://gerrit.cloudera.org:8080/#/c/24122/1/src/kudu/tools/tool_action_test.cc@425 PS1, Line 425: s = ProcessRequest(req, &resp, &cluster, &leave_files); IIUC, it's possible to deduce the leave_files setting based on ControlShellRequestPB instance after it's populated by the protocol.ReceiveMessage() above. Why to pass it as an output parameter into ProcessRequest() then? -- To view, visit http://gerrit.cloudera.org:8080/24122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa09d63d614190d25cb9b1c6706fd0db992eb5eb Gerrit-Change-Number: 24122 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Mar 2026 02:27:17 +0000 Gerrit-HasComments: Yes
