Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24092 )
Change subject: [fs] add metrics for untracked orphaned blocks ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet.cc@1988 PS2, Line 1988: metrics_->orphaned_block_cleanup_failures->IncrementBy(stats.blocks_failed); : metrics_->orphaned_block_cleanup_failures_bytes->IncrementBy(stats.bytes_failed); Are these metrics updated multiple times with the same participant blocks when retrying deletion of the blocks that failed to be deleted previous run of the tablet's metadata flush? If so, this might become confusing and end up in inflated and scary metrics. http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metrics.h File src/kudu/tablet/tablet_metrics.h: http://gerrit.cloudera.org:8080/#/c/24092/2/src/kudu/tablet/tablet_metrics.h@94 PS2, Line 94: scoped_refptr<Histogram> bloom_lookups_per_op; Does it make sense to introduce a gauge to reflect on the size of the blocks currently pending removal in addition to this accumulating counter? It might be used instead in https://gerrit.cloudera.org/#/c/24125 for setting retained_bytes stats for the corresponding maintenance op. -- To view, visit http://gerrit.cloudera.org:8080/24092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id386d9fc8d0900839e229e66772f35299b3ef2e9 Gerrit-Change-Number: 24092 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 24 Mar 2026 23:01:32 +0000 Gerrit-HasComments: Yes
