Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24127 )
Change subject: [examples] add replication demo ...................................................................... Patch Set 1: (5 comments) Thanks for the comments and review Gabi! Let me know if you find anything else. http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/Makefile File examples/flink-replication/Makefile: http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/Makefile@70 PS1, Line 70: cp "$(REPO_ROOT)"/java/kudu-replication/build/libs/kudu-replication-*SNAPSHOT.jar \ : "$(JAR_DIR)/" > Is it a possibility that there are multiple kudu-replication-*SNAPSHOT.jar Good point. Yes this can happen if multiple versions of snapshot jars are built in the java project. Added a check here to assert that only jar is present in the flink jar dir. http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/README.md File examples/flink-replication/README.md: http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/README.md@143 PS1, Line 143: - Discovery interval: 2 s > Here it says the discovery interval is 2 seconds, but in .env line 38 it sa Done http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/README.md@196 PS1, Line 196: The pool is capped at 500 IDs > In ingest.py line 96 it says POOL_MAX = 2000. Done http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/docker-compose.yml File examples/flink-replication/docker-compose.yml: http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/docker-compose.yml@29 PS1, Line 29: # docker compose --profile writer up -d # also start the kudu-writer container > Isn't this profile supposed to be ingest? Done http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/flink/submit-job.sh File examples/flink-replication/flink/submit-job.sh: http://gerrit.cloudera.org:8080/#/c/24127/1/examples/flink-replication/flink/submit-job.sh@116 PS1, Line 116: read -r -p " Continue anyway? [y/N] " confirm : if [[ ! "${confirm}" =~ ^[Yy]$ ]]; then > Is this script intended only for manual local use? Or should it also work i After second thought I figured that here an error message and exit should be enough. removed this part. -- To view, visit http://gerrit.cloudera.org:8080/24127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iebf29efaebc91d9831f57fc884a2acbab31715ce Gerrit-Change-Number: 24127 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 09:28:59 +0000 Gerrit-HasComments: Yes
