Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24134 )
Change subject: [fs] fix partial blocks deletion case in rocksdb ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24134/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/24134/1/src/kudu/fs/log_block_manager.cc@2128 PS1, Line 2128: // Purge the blocks that failed to delete. Shouldn't this say something like this: "trim to only the committed deletions."? http://gerrit.cloudera.org:8080/#/c/24134/1/src/kudu/fs/log_block_manager.cc@2169 PS1, Line 2169: committed_count += batch_count; Nit: write_count isn't incremented here after the final flush succeeds, unlike the mid-loop path. Since it's only used for test injection this is harmless, but for consistency should it be incremented here too? -- To view, visit http://gerrit.cloudera.org:8080/24134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifb553fbf9a88f0cdb392f926289bbdf5f18b5d29 Gerrit-Change-Number: 24134 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 11:47:14 +0000 Gerrit-HasComments: Yes
