Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24125 )
Change subject: KUDU-829 Add online gc op to clean orphaned blocks ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_metadata.cc@624 PS2, Line 624: } should we also have: metrics_->orphaned_block_cleanup_failures->IncrementBy(s.blocks_failed) if non-zero? Since blocks_failed is calculated above? http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_metrics.cc File src/kudu/tablet/tablet_metrics.cc: http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_metrics.cc@254 PS2, Line 254: "Number of orphaned blocks deleted during tablet metadata load at startup." nit: add extra trailing space http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_mm_ops-test.cc File src/kudu/tablet/tablet_mm_ops-test.cc: http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_mm_ops-test.cc@246 PS2, Line 246: againa nit: again http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_mm_ops.cc File src/kudu/tablet/tablet_mm_ops.cc: http://gerrit.cloudera.org:8080/#/c/24125/2/src/kudu/tablet/tablet_mm_ops.cc@419 PS2, Line 419: stats->set_data_retained_bytes(static_cast<int64_t>(num_pending)); set_data_retained_bytes is being set to the raw block count rather than an actual byte estimate. Since the maintenance manager uses this field to compare scheduling priority across all ops (e.g. against UndoDeltaBlockGCOp, which reports real byte sizes), a small number of orphaned blocks will always be outweighed. Should this use a minimum floor value, or at least a per-block byte estimate, to ensure the op is not perpetually starved when other ops report large byte counts? -- To view, visit http://gerrit.cloudera.org:8080/24125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I732133b460df2fe4c91d05f420dda6f0274d440e Gerrit-Change-Number: 24125 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 25 Mar 2026 12:19:55 +0000 Gerrit-HasComments: Yes
