Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24157 )
Change subject: Fix misleading Javadoc for writer.maxBufferSize ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24157/1//COMMIT_MSG@14 PS1, Line 14: The confusion likely stems from the parameter name in the Flink : connector (KuduWriterConfig.maxBufferSize), which implies a byte : quantity, while the connector's own source comment clarifies: : "Reference from AsyncKuduSession mutationBufferMaxOps 1000." Why not change the name everywhere so that it is no more confusing? Even with fixed comment, variable name may still lead to confusion. http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java File java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java: http://gerrit.cloudera.org:8080/#/c/24157/1/java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java@155 PS1, Line 155: <li>{@code writer.maxBufferSize} (optional) – maximum number of operations buffered in the : * Kudu write session (maps to {@code mutationBufferMaxOps})</li> Do you think TestReplicationConfigParser.java also needs to change here: ++ 229 public void testWriterConfigAllParamsPresent() { 230 String[] args = { 231 "--writer.flushMode", "AUTO_FLUSH_SYNC", 232 "--writer.operationTimeout", "60000", 233 "--writer.maxBufferSize", "5242880", >>>> 234 "--writer.flushInterval", "2000", 235 "--writer.ignoreNotFound", "true", 236 "--writer.ignoreDuplicate", "true" 237 }; +++ -- To view, visit http://gerrit.cloudera.org:8080/24157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e79b888ecc4bd0ef815aeadec9003027b7d6b3a Gerrit-Change-Number: 24157 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 01 Apr 2026 06:02:49 +0000 Gerrit-HasComments: Yes
