Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/24173 )
Change subject: [rpc] add PREDICT_FALSE() for unlikely error scenarios
......................................................................
[rpc] add PREDICT_FALSE() for unlikely error scenarios
I was looking at the RPC code to clarify a few perf-related questions
and found that PREDICT_{TRUE,FALSE}() were not used uniformly throughout
the code. This patch adds these macros in the rest of relevant places,
where applicable.
This changelist doesn't contain any functional modifications.
Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Reviewed-on: http://gerrit.cloudera.org:8080/24173
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/client_negotiation.h
M src/kudu/rpc/connection.cc
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/messenger.cc
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/outbound_call.cc
M src/kudu/rpc/proxy.cc
M src/kudu/rpc/reactor.cc
M src/kudu/rpc/rpc_controller.cc
M src/kudu/rpc/rpc_sidecar.cc
M src/kudu/rpc/serialization.cc
M src/kudu/rpc/service_pool.cc
13 files changed, 47 insertions(+), 46 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24173
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3178a37ec371ca4db2b818a67cf04f52b72f2dd0
Gerrit-Change-Number: 24173
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
