Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24152 )
Change subject: fix flaky TestTableStatistics stat assertions ...................................................................... fix flaky TestTableStatistics stat assertions `live_row_count` and `on_disk_size` return -1 when the master has not yet received a tablet-server heartbeat carrying the stat. Tests that asserted >= 0 immediately after table creation could therefore fail intermittently. Replace the narrowly-scoped `_wait_for_live_row_count` helper with a generic `_wait_for_stat(client, table_name, get_stat, min_value)` that accepts a callable to extract any stat field. All stat assertions in TestTableStatistics now poll through this helper instead of reading stats once and asserting immediately. Change-Id: I6d5cd69802ec2139e8df4c87903e3c6196e26ae3 Reviewed-on: http://gerrit.cloudera.org:8080/24152 Tested-by: Kudu Jenkins Reviewed-by: Gabriella Lotz <[email protected]> Reviewed-by: Zoltan Chovan <[email protected]> --- M python/kudu/tests/test_client.py 1 file changed, 39 insertions(+), 26 deletions(-) Approvals: Kudu Jenkins: Verified Gabriella Lotz: Looks good to me, but someone else must approve Zoltan Chovan: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/24152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6d5cd69802ec2139e8df4c87903e3c6196e26ae3 Gerrit-Change-Number: 24152 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
