Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24158 )
Change subject: [tablet] optimize MemRowSet scan to single-pass changelist application ...................................................................... Patch Set 2: Code-Review+1 (1 comment) just a nit, else looks good to me. Thank you! http://gerrit.cloudera.org:8080/#/c/24158/2/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/24158/2/src/kudu/tablet/memrowset-test.cc@286 PS2, Line 286: void InsertWideRow(MemRowSet* mrs, const Schema& schema, nit: The three helpers are defined as `void` and use `CHECK_OK` internally. For test helpers it is more idiomatic in Kudu to return `Status` (or use `ASSERT_OK` inside a `TEST_F`). -- To view, visit http://gerrit.cloudera.org:8080/24158 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ccdfcf207680261907d025b64a9b046bb108f13 Gerrit-Change-Number: 24158 Gerrit-PatchSet: 2 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Comment-Date: Tue, 14 Apr 2026 13:56:21 +0000 Gerrit-HasComments: Yes
