Hello Zoltan Chovan, Alexey Serbin, Zoltan Martonka, Gabriella Lotz, Kudu 
Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24278

to look at the new patch set (#2).

Change subject: KUDU-3693: Add bearer token auth for Prometheus
......................................................................

KUDU-3693: Add bearer token auth for Prometheus

Prometheus does not support SPNEGO, so scraping a secured
Kudu cluster was previously impossible. Add
--webserver_prometheus_token: when set, designated Prometheus
endpoints (/metrics_prometheus, /prometheus-sd) require an
'Authorization: Bearer <token>' header instead of SPNEGO.

Adds unit tests in webserver-test.cc and integration tests in
prometheus_auth-itest.cc covering correct, wrong, and missing
token scenarios for both scrape and SD endpoints.

Example Prometheus configs for using the Bearer token:

Static scrape config:
    global:
    scrape_configs:
    - job_name: kudu
        metrics_path: /metrics_prometheus
        scrape_interval: 2s
        authorization:
        type: Bearer
        credentials: <webserver_prometheus_token>
        static_configs:
        - targets:
            - 127.0.0.1:8050
            - 127.0.0.1:8051
            - 127.0.0.1:8052

SD scrape config:
    global:
    scrape_configs:
    - job_name: kudu
        metrics_path: /metrics_prometheus
        scrape_interval: 2s
        authorization:
        type: Bearer
        credentials: <webserver_prometheus_token>
        http_sd_configs:
        - url: http://127.0.0.1:8050/prometheus-sd
            refresh_interval: 2s
            authorization:
            type: Bearer
            credentials: <webserver_prometheus_token>
        - url: http://127.0.0.1:8051/prometheus-sd
            refresh_interval: 2s
            authorization:
            type: Bearer
            credentials: <webserver_prometheus_token>
        - url: http://127.0.0.1:8052/prometheus-sd
            refresh_interval: 2s
            authorization:
            type: Bearer
            credentials: <webserver_prometheus_token>

Change-Id: If8169196a2c49d64865095f3bc6da1d3bfbcecfb
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/prometheus_auth-itest.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/server/webserver_options.cc
M src/kudu/server/webserver_options.h
M src/kudu/util/mini_prometheus.cc
M src/kudu/util/mini_prometheus.h
11 files changed, 479 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/24278/2
--
To view, visit http://gerrit.cloudera.org:8080/24278
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If8169196a2c49d64865095f3bc6da1d3bfbcecfb
Gerrit-Change-Number: 24278
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>

Reply via email to