Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24246 )
Change subject: KUDU-3767 Add global leader awareness to auto leader rebalancer ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24246/2/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24246/2/src/kudu/master/auto_leader_rebalancer-test.cc@543 PS2, Line 543: and_schema().empty()); > This test doesn’t actually exercise the new global tie-breaker. With 3 tser Done http://gerrit.cloudera.org:8080/#/c/24246/2/src/kudu/master/auto_leader_rebalancer-test.cc@557 PS2, Line 557: on ts0: {2, 0, 0}. > maybe extract this to a const string, and re-use instead of reading it back Done http://gerrit.cloudera.org:8080/#/c/24246/2/src/kudu/master/auto_leader_rebalancer-test.cc@566 PS2, Line 566: ST_F(LeaderRebalancerTest, MultiTableLeaderB > would it be possible to change this to some sort of assert_eventually block Done -- To view, visit http://gerrit.cloudera.org:8080/24246 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I47e266d2a06d5c18a50270e0d5e9d4954480f308 Gerrit-Change-Number: 24246 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Wed, 20 May 2026 11:03:49 +0000 Gerrit-HasComments: Yes
