Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24285 )
Change subject: [auto_rebalancer] close TODO in CheckMoveCompleted ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24285/1/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24285/1/src/kudu/master/auto_rebalancer.cc@874 PS1, Line 874: // via tserver-to-master heartbeats and may lag the tserver's actual Raft : // state by up to one heartbeat interval. Immediately after BulkChangeConfig : // succeeds, the destination peer may not yet appear in CatalogManager -- : // indistinguishable from it having been genuinely evicted by Raft. The RPC > I have updated the comment. Thanks for refining the comment. I think there is still a way to source the information on replica membership from the catalog manager, and not issuing GetConsensusState RPC directly to the Raft leader. One can distinguish between the updated and the prior (not-yet-updated) Raft config using the config index. That's how we achieve atomicity on BulkChangeConfig -- the CAS-style semantics for config index in based on that. IIRC, the catalog manager receives information on config index as well. Yes, it will introduce a bit of extra complexity into the logic, but it will reduce the number of RPCs sent. Does it make sense? If so but you don't plan trying this approach, at least please add back the TODO tag. Maybe, also add a few sentences to clarify on the idea for posterity, so it's easier to comprehend. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/24285 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba021539fbfaca5905fbbf4abbb6e2a61db1f7dc Gerrit-Change-Number: 24285 Gerrit-PatchSet: 2 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 21 May 2026 16:54:35 +0000 Gerrit-HasComments: Yes
