Marton Greber has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24109 )

Change subject: Fix TSAN data races in KuduScanner keep-alive callback
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

LGTM, just one nit.
Maybe you can also put into the commit message what the repro test was 
consistently failing previously and now works consistently.
Thanks!

http://gerrit.cloudera.org:8080/#/c/24109/5/src/kudu/client/scanner-internal.h
File src/kudu/client/scanner-internal.h:

http://gerrit.cloudera.org:8080/#/c/24109/5/src/kudu/client/scanner-internal.h@329
PS5, Line 329: mutable
nit: is mutable needed here?



--
To view, visit http://gerrit.cloudera.org:8080/24109
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b915879f717e6909e2d49b3bfa9360dd428cc89
Gerrit-Change-Number: 24109
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 28 May 2026 10:08:32 +0000
Gerrit-HasComments: Yes

Reply via email to