Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24374 )
Change subject: Add TLS support to MiniHms ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/24374/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24374/1//COMMIT_MSG@7 PS1, Line 7: Add TLS support to MiniHms nit: maybe include the ticket in the title: KUDU-3781? http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/hms_client-test.cc@117 PS1, Line 117: ASSERT_OK(hms.Stop()); If any of the earlier assert macros fail, the function returns immediately (via `ASSERT_*` short-circuit), so `hms.Stop()` is never called and the HMS process is leaked for the duration of the test. http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/mini_hms.cc File src/kudu/hms/mini_hms.cc: http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/mini_hms.cc@268 PS1, Line 268: if (env->FileExists(success_marker) && env->FileExists(server_key_store)) { : return Status::OK(); : } : : for (const auto& path : { ca_key_store, : server_key_store, : ca_cert, : server_csr, : server_cert, : success_marker }) { : if (env->FileExists(path)) { : RETURN_NOT_OK(env->DeleteFile(path)); : } : } Is this caching ever used? Aren't test files cleaned up after test execution anyway? http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/mini_hms.cc@325 PS1, Line 325: genkey "This command was named -genkey in earlier releases. The old name is still supported in this release. The new name, -genkeypair, is preferred going forward." [1] (at the bottom of the -genkeypair section) [1]: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/keytool.html http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/mini_hms.cc@335 PS1, Line 335: deststoretype If i'm not mistaken this should be -storetype. [1] ( -genkeypair lists {-storetype type}: Keystore type. deststoretype is listed under importkeystore ) (Its probably silently ignored and using the Java 9+ default that is pkcs12. Just wanted to point this out) [1]: https://docs.oracle.com/en/java/javase/17/docs/specs/man/keytool.html http://gerrit.cloudera.org:8080/#/c/24374/1/src/kudu/hms/mini_hms.cc@361 PS1, Line 361: import here and below: "This command was named -import in earlier releases. This old name is still supported in this release. The new name, -importcert, is preferred." [1] [1]: https://docs.oracle.com/en/java/javase/17/docs/specs/man/keytool.html (very bottom of the page) -- To view, visit http://gerrit.cloudera.org:8080/24374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fca647fd900fafc6d737c93a4af4565631839b7 Gerrit-Change-Number: 24374 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 28 May 2026 12:31:15 +0000 Gerrit-HasComments: Yes
