Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/24383 )
Change subject: KUDU-3781: add TLS transport support for HMS client ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_catalog.cc@76 PS3, Line 76: DEFINE_bool(hive_metastore_tls_use_https_trusted_ca_cert, true, > From what I can see, --trusted_certificate_file is currently used for verif I guess the more important separation is that one controls the internal Kudu communication (which normally uses IPKI instead of external CA-signed certs), the other controls communication between Kudu and third-party services. Anyway, I'm fine with this approach as long as the default is to control all third-party with a single flag. Adding the option to control this separately doesn't hurt. http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc File src/kudu/hms/hms_client-test.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/hms/hms_client-test.cc@615 PS3, Line 615: ASSERT_OK(StartHmsNoCluster(&hms, /*tls_enabled=*/false)); Would it make sense to use a tri-state flag with 'optional' default similar to rpc_encryption? http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/24383/3/src/kudu/integration-tests/master_hms-itest.cc@104 PS3, Line 104: // NOTE: In case of possible conflicts with a newly added scenario that need > Please see HmsClientTest.TlsEnabledOnlyOnClient for the expected behavior: Yep thanks, missed that. -- To view, visit http://gerrit.cloudera.org:8080/24383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9658323ed9aebdfdf8e6847c9c3129f5c8517c65 Gerrit-Change-Number: 24383 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2026 09:00:30 +0000 Gerrit-HasComments: Yes
