Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: WIP KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/cfile/CMakeLists.txt File src/kudu/cfile/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/cfile/CMakeLists.txt@33 PS1, Line 33: return() I'm not sure all these early returns are needed as long as you use -DKUDU_CLIENT_INSTALL=OFF \ -DKUDU_MASTER_INSTALL=OFF \ -DKUDU_TSERVER_INSTALL=OFF and make kudu_client kudu_client_exported http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/src/kudu/util/CMakeLists.txt@361 PS1, Line 361: set(UTIL_LIBS ${UTIL_LIBS} yaml) Could be list(APPEND UTIL_LIBS yaml) http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh File thirdparty/build-if-necessary.sh: http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh@36 PS1, Line 36: "client") How does this get selected? -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 10 Jun 2026 22:32:00 +0000 Gerrit-HasComments: Yes
