Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24435 )
Change subject: WIP KUDU-3780: introduce KUDU_CLIENT_ONLY build option ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24435/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/24435/1/CMakeLists.txt@1512 PS1, Line 1512: if (UNIX) > IIUC this overwrites GENERATED_HEADERS_DEPS rather than appending: That's right -- it was a bug/typo, I noticed that as well. This is already fixed at least as of PS2. Also, fb-gen should be a part of the generated-headers target since it build flatbuffers that client library uses. That's also addressed now. http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh File thirdparty/build-if-necessary.sh: http://gerrit.cloudera.org:8080/#/c/24435/1/thirdparty/build-if-necessary.sh@36 PS1, Line 36: ;; > Ah, so we run build-if-necessary.sh explicitly before CMake. But build-if-n The TODO is written to from the perspective of changing the former 'common' group to become common for both the case when building client-only dependencies and everything. I thought that would become 'common', 'common_server' and 'common_client' groups. It turned out that nothing but sparsehash from the former 'common' group is needed if building client-only. So, I decided to keep it as-is. -- To view, visit http://gerrit.cloudera.org:8080/24435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc8b021e03808a3ca8da6cfff617bc913772f271 Gerrit-Change-Number: 24435 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2026 05:15:54 +0000 Gerrit-HasComments: Yes
