Zoltan Chovan has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24480 )
Change subject: [java] Refactor disabling publishing ...................................................................... [java] Refactor disabling publishing The publishing of internal modules (e.g. kudu-backup-common, kudu-subprocess, etc.) was supposed to be disabled, however Gradle still ran the per-publication publish tasks. Added a shared disablePublishing() helper method, that disables both lifecycle and per-publication publish tasks, preventing internal modules to be published/installed during release or local testing. To confirm the change works as expected, the following manual test was done: With and without this patch, a local publishing was executed with: ./gradlew publishToMavenLocal \ -Dmaven.repo.local=<publish directory> \ -PskipSigning \ -Pflatc=~/CLionProjects/kudu/thirdparty/installed/common/bin/flatc Then the generated output was compared: $ ls -l /tmp/kudu-with-publish-patch/org/apache/kudu/ total 0 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-backup-tools drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-backup3_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-client drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-hive drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-replication drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-spark3_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-spark3-tools_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:32 kudu-test-utils $ ls -l /tmp/kudu-without-publish-patch/org/apache/kudu/ total 0 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-backup-common drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-backup-tools drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-backup3_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-client drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-flatbuffers drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-hive drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-proto drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-replication drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-spark3_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-spark3-tools_2.12 drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-subprocess drwxr-xr-x@ 4 zchovan wheel 128 Jun 19 15:35 kudu-test-utils The modules that are were marked not to be published are no longer present in the listing. Change-Id: Ib28ef8374074928f614ae346649cc7f886fb833b Reviewed-on: http://gerrit.cloudera.org:8080/24480 Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Gabriella Lotz <[email protected]> --- M java/gradle/publishing.gradle M java/kudu-backup-common/build.gradle M java/kudu-flatbuffers/build.gradle M java/kudu-jepsen/build.gradle M java/kudu-proto/build.gradle M java/kudu-subprocess/build.gradle 6 files changed, 18 insertions(+), 11 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified Gabriella Lotz: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/24480 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib28ef8374074928f614ae346649cc7f886fb833b Gerrit-Change-Number: 24480 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
