Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24581 )
Change subject: [thirdparty] update boost up 1.91.0 ...................................................................... Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@18 PS5, Line 18: does : not exist anymore nit: no longer exists http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@20 PS5, Line 20: since 1.86.0 nit: as of 1.86.0 http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@20 PS5, Line 20: random generators switched nit: random generators were switched http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@30 PS5, Line 30: at github.com nit: on GitHub http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@32 PS5, Line 32: into to http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@33 PS5, Line 33: thirdparty third-party http://gerrit.cloudera.org:8080/#/c/24581/5//COMMIT_MSG@33 PS5, Line 33: into to the http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/24581/2/thirdparty/build-definitions.sh@971 PS2, Line 971: # locale: Thrift : # serialization: Kudu : # signals2: Kudu > I didn't verify whether they can or cannot in this particular case (but I g Some of the build_xxx() functions (build_libcxxabi, build_libcxx, build_gflags, etc) do make use of -DCMAKE_CXX_FLAGS. But, I am fine with addressing this in a separate patch. http://gerrit.cloudera.org:8080/#/c/24581/5/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/24581/5/thirdparty/build-definitions.sh@954 PS5, Line 954: BOOST_LDFLAGS="-stdlib=libc++ $BOOST_LDFLAGS" Is this required? We seem to be setting 'EXTRA_LDFLAGS' with all this already inside thirdparty/build-thirdparty.sh before calling 'build_boost tsan'. http://gerrit.cloudera.org:8080/#/c/24581/5/thirdparty/build-definitions.sh@965 PS5, Line 965: e.g, nit: e.g., -- To view, visit http://gerrit.cloudera.org:8080/24581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c9c2e9260b892c721ec2ba887c61b8aeef35888 Gerrit-Change-Number: 24581 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 16 Jul 2026 13:29:52 +0000 Gerrit-HasComments: Yes
