Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/24525 )
Change subject: KUDU-3789 auto_rebalancer: reliably clear replace marker after failed moves ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24525/2/src/kudu/master/auto_rebalancer.cc File src/kudu/master/auto_rebalancer.cc: http://gerrit.cloudera.org:8080/#/c/24525/2/src/kudu/master/auto_rebalancer.cc@1079 PS2, Line 1079: HostPort leader_hp; : // Resolving the leader also re-checks our own catalog leadership (it takes the : // leader lock), so if we've lost it here, or there's no tablet leader yet, we : // bail out and the caller leaves the marker pending. : RETURN_NOT_OK(GetTabletLeader(move.tablet_uuid, &leader_uuid, &leader_hp)); : vector<Sockaddr> resolved; : RETURN_NOT_OK(leader_hp.ResolveAddre > Thank you for the update. Thanks, that matches my understanding too. I've added a comment covering the residual race and why it's not a problem. On the CAS value from the move: I don't think we can use it, since move.config_opid_idx was read before the move set 'replace' and so predates the marker we're clearing. That's why I read the current opid straight from the leader. -- To view, visit http://gerrit.cloudera.org:8080/24525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia47698207612252bca3ec70fc090a37bd3f87809 Gerrit-Change-Number: 24525 Gerrit-PatchSet: 4 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 14:16:00 +0000 Gerrit-HasComments: Yes
