Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24583 )

Change subject: KUDU-3788 an option to use pre-built thirdparty artifacts
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24583/4/thirdparty/prebuilt-utils.sh
File thirdparty/prebuilt-utils.sh:

http://gerrit.cloudera.org:8080/#/c/24583/4/thirdparty/prebuilt-utils.sh@163
PS4, Line 163:   # Building a variable in the xxx_NAME form: vars.sh contains 
corresponding
             :   # versioned strings for all the 3rd-party components.
             :   local version_var="${name}_VERSION"
             :   local version="${!version_var}"
             :   if [ -z "$version" ]; then
             :     echo "ERROR: $version_var isn't defined: check vars.sh" >&2
             :     exit 1
             :   fi
             :   local plevel_var="${name}_PATCHLE
> If the patch version is reflected in the value of the corresponding xxx_VER
After some consideration, I added patch version into the name of the pre-built 
archive.  So, for cmake built for macOS 26.5.2 it looks like below 
(CMAKE_VERSION=3.25.3, CMAKE_PATCHLEVEL=2):

  cmake-3.25.3.p2.macos-26.x86_64.clang-17.0.tar.xz

Thanks a lot for the input!



--
To view, visit http://gerrit.cloudera.org:8080/24583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I55b5b99fcbe60eec3f6ae19fa4f2e335f361d143
Gerrit-Change-Number: 24583
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Wed, 29 Jul 2026 00:57:20 +0000
Gerrit-HasComments: Yes

Reply via email to