Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24591 )
Change subject: KUDU-3789 Deflake auto_leader_rebalancer-test ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/24591/3/src/kudu/master/auto_leader_rebalancer-test.cc File src/kudu/master/auto_leader_rebalancer-test.cc: http://gerrit.cloudera.org:8080/#/c/24591/3/src/kudu/master/auto_leader_rebalancer-test.cc@505 PS3, Line 505: // Keep the tablet count modest so natural-election churn under TSAN doesn't : // perpetually prevent an exactly balanced leader snapshot. Divisible by the : // tserver count for a clean balance target. : const int kNumTablets = 24; I'm curious why the original choice was 59. Probably, there was an idea to see how the rebalancer behaves when the balance balance isn't 'clean', and maybe that's a good idea to keep it at least for non-TSAN builds. If it makes sense, consider different settings for kNumTablets based on whether it's a sanitized build or not. It's quite a common theme: search for THREAD_SANITIZER and ADDRESS_SANITIZER in alter_table-test.cc and other tests. http://gerrit.cloudera.org:8080/#/c/24591/3/src/kudu/master/auto_leader_rebalancer-test.cc@1019 PS3, Line 1019: FLAGS_leader_failure_max_missed_heartbeat_periods = 15.0; ditto: consider introducing this customization only for THREAD_SANITIZER case -- perhaps, it makes sense to test how auto-leader rebalancing behaves with default settings in other type of builds where the rate of spurious re-elections is not that high, but a few re-elections can happen during the course of leader rebalancing. -- To view, visit http://gerrit.cloudera.org:8080/24591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00224fddfead0fb462e793f085d935b597792aaa Gerrit-Change-Number: 24591 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Sat, 01 Aug 2026 00:20:16 +0000 Gerrit-HasComments: Yes
