Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: Add diff-scan option to return unobservable rows ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/24578/6/src/kudu/client/client.cc@1925 PS6, Line 1925: visibility == DiffScanRowVisibility::OBSERVABLE_ONLY ); Should this be `visibility == INCLUDE_UNOBSERVABLE`? As written, OBSERVABLE_ONLY sets include_unobservable_rows=true -- looks inverted, and would explain the failing INCLUDE_UNOBSERVABLE scenarios. -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 14:42:27 +0000 Gerrit-HasComments: Yes
