Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24687 )

Change subject: KUDU-3788 download source archives by demand only
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/24687/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24687/1//COMMIT_MSG@1
PS1, Line 1: Parent:     565fa2a0 (remove std::move on optional<MonoTime> 
deadline)
Not related to this patch, low priority: If a package version has changed and 
scripts download the latest source, the old directory remains there occupying 
the space. We could think about cleaning up those.


http://gerrit.cloudera.org:8080/#/c/24687/1//COMMIT_MSG@11
PS1, Line 11: would be still
would still be


http://gerrit.cloudera.org:8080/#/c/24687/1//COMMIT_MSG@16
PS1, Line 16: by
only


http://gerrit.cloudera.org:8080/#/c/24687/1//COMMIT_MSG@17
PS1, Line 17: However, it's no longer used when running
            : build-if-necessary.sh.
With this change, make sure to verify the documentation inside:
docs/installation.adoc
docs/contributing.adoc

is inline with this.


http://gerrit.cloudera.org:8080/#/c/24687/1/thirdparty/download-thirdparty.sh
File thirdparty/download-thirdparty.sh:

http://gerrit.cloudera.org:8080/#/c/24687/1/thirdparty/download-thirdparty.sh@83
PS1, Line 83: $comp
"$comp"



--
To view, visit http://gerrit.cloudera.org:8080/24687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51a1822070f6e37726e4efd53ba5e536c9eb8fb9
Gerrit-Change-Number: 24687
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Thu, 13 Aug 2026 07:00:35 +0000
Gerrit-HasComments: Yes

Reply via email to