Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24578 )
Change subject: KUDU-3800 Add diff-scan option to return unobservable rows ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/24578/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24578/9//COMMIT_MSG@49 PS9, Line 49: bool enum? http://gerrit.cloudera.org:8080/#/c/24578/9/src/kudu/tablet/delta_applier.cc File src/kudu/tablet/delta_applier.cc: http://gerrit.cloudera.org:8080/#/c/24578/9/src/kudu/tablet/delta_applier.cc@30 PS9, Line 30: #include "kudu/common/common.pb.h" why is this included here along with no_include pragma below for the same header file? http://gerrit.cloudera.org:8080/#/c/24578/9/src/kudu/tablet/memrowset.cc File src/kudu/tablet/memrowset.cc: http://gerrit.cloudera.org:8080/#/c/24578/9/src/kudu/tablet/memrowset.cc@576 PS9, Line 576: unset_in_sel_vector nit: See if this be set to some default value to keep it clean. -- To view, visit http://gerrit.cloudera.org:8080/24578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d0727fb2b89c727c669ec218e3bb8594336359a Gerrit-Change-Number: 24578 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 06:46:51 +0000 Gerrit-HasComments: Yes
