Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24705 )
Change subject: [thirdparty] skip building unused LLVM/CLANG tools ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@7 PS1, Line 7: skip building unused LLVM/CLANG tools Because those are in the 'extra' subdir: those tools aren't invoked by LLVM/CLANG toolchain on its own, but they are stand-alone tools. From the extra tools, we only use iwyu. Building many of them was already turned off (that's why the long list), these are just extra that probably appeared in newer LLVM versions (since LLVM 4.0) but were not put into the list. > There are some other tools inside 'thirdparty/src/llvm-11.0.0.src/tools/' > that don't seem to be applicable to Kudu, e.g., > llvm-microsoft-demangle-fuzzer, msbuild, etc. > > Should those also be skipped? Those aren't built already. As for the list of the LLVM tools that are build now, most of them can be used by the LLVM/CLANG toolchain internally during build and codegeneration, and I didn't have a chance to focus on clarifying which exactly are invoked during Kudu build or codegen. Feel free to clarify on this if you have a chance: it's always OK to post a follow-up update to remove more unused tools. http://gerrit.cloudera.org:8080/#/c/24705/1//COMMIT_MSG@11 PS1, Line 11: reduce build times > It would be great if you could also add some build metrics showcasing redu I posted stats on the archive size reduction. As for the build times, I'm not sure it's worth it to recompile LLVM just to produce those stats: by default we now use pre-built artifacts/archives, and it's certainly less time compiling with this patch than before. http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/24705/1/thirdparty/vars.sh@357 PS1, Line 357: LLVM_PATCHLEVEL=11 > nit: Is this to trigger a rebuild? If it is already built, there is no harm No, this isn't for triggering a rebuild. This is for properly naming pre-built archives and differentiating between them. -- To view, visit http://gerrit.cloudera.org:8080/24705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8efa4c3cd4edfa788d633c32debdec1b63b48ea Gerrit-Change-Number: 24705 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 14:56:54 +0000 Gerrit-HasComments: Yes
