Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24683 )
Change subject: KUDU-3761 prefer follower moves cross-location ...................................................................... Patch Set 5: Code-Review+1 (2 comments) Overall looks good to me. Just a couple of questions. http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo-test.cc@1684 PS5, Line 1684: // LocationBalancingAlgo must prefer a source that hosts a non-leader replica Do you think an integration test is also required to test the end-to-end functionality? http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo.h File src/kudu/rebalance/rebalance_algo.h: http://gerrit.cloudera.org:8080/#/c/24683/5/src/kudu/rebalance/rebalance_algo.h@313 PS5, Line 313: bool prefer_follower_moves = true Do you think it would make sense to force callers to provide the value explicitly, to avoid any surprises if flag default changes? -- To view, visit http://gerrit.cloudera.org:8080/24683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a162a227071caf37d572ba60c2bc49608d14e65 Gerrit-Change-Number: 24683 Gerrit-PatchSet: 5 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2026 09:59:02 +0000 Gerrit-HasComments: Yes
