Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/24813 )
Change subject: Fix PostgreSQL 17.2 build on macOS: don't detect memset_s(). ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/24813/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24813/1//COMMIT_MSG@9 PS1, Line 9: macOS ships memset_s() in libSystem, so PostgreSQL's AC_CHECK_FUNCS link Perhaps, it makes sense to mention that this issue surfaced after introducing -std=c17 flag into CFLAGS in one of the recent updates. http://gerrit.cloudera.org:8080/#/c/24813/1//COMMIT_MSG@15 PS1, Line 15: The simplest fix (and analogous to the strchrnul() workaround already : carried) is to drop memset_s from the AC_CHECK_FUNCS list. PostgreSQL's : explicit_bzero.c has a portable fallback (indirect call through a : volatile pointer to plain memset) that will be used when HAVE_MEMSET_S : is undefined. In 3rd-party, we strive to reuse/back-port patches from the upstream instead of hacks -- it gives less surprises down the road. That's a similar case, and importing this patch from the upstream addresses the issue for me at least on macOS x86_64: https://github.com/postgres/postgres/commit/12eee85e511ff8854ac61e8caad8cec218b20513 -- To view, visit http://gerrit.cloudera.org:8080/24813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I230d71ba4b8cc6d5dc9afb4e8bd45d8c523b246b Gerrit-Change-Number: 24813 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 10 Sep 2026 17:24:06 +0000 Gerrit-HasComments: Yes
