Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24618 )
Change subject: KUDU-3734 Compaction budget refinements and observability ...................................................................... Patch Set 9: Code-Review+2 (1 comment) I have 1 question. If it is not a problem, the +2. http://gerrit.cloudera.org:8080/#/c/24618/9/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/24618/9/src/kudu/tablet/rowset_info.cc@475 PS9, Line 475: extra_->size_bytes = rs->OnDiskSize(); : extra_->has_bounds = rs->GetBounds(&extra_->min_key, &extra_->max_key).ok(); : // Compute the budget-weighted size for compaction knapsack accounting. : // OnDiskBaseDataSizeWithDeltas() returns the exact physical footprint : // (base + redo + undo). We apply --rowset_deltas_size_include_undo and : // --rowset_undo_deltas_budget_weight here so that the low-level accessor : // stays free of policy concerns. : uint64_t undo_bytes = rs->OnDiskUndoDeltasSize(); Is there any theoretical chance that updates and delta compaction happens between OnDiskSize() and OnDiskUndoDeltaSize()? If the thread would stop between 2 calls, and we would append multiple undo for each rows, could undo_bytes go over size_bytes and cause an integer overflow? -- To view, visit http://gerrit.cloudera.org:8080/24618 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id63db0006c77ad1d55eb2119d99ee64499435819 Gerrit-Change-Number: 24618 Gerrit-PatchSet: 9 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 11 Sep 2026 10:12:51 +0000 Gerrit-HasComments: Yes
