Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/24863 )
Change subject: KUDU-3761 drop default for prefer_follower_moves ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Thank you for addressing the comments. I just have one question regarding the comment text. Rest looks good to me. http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc File src/kudu/rebalance/rebalance_algo-test.cc: http://gerrit.cloudera.org:8080/#/c/24863/2/src/kudu/rebalance/rebalance_algo-test.cc@221 PS2, Line 221: /*prefer_follower_moves=*/true > There is a false case, just not through this helper: PreferFollowerMovesByT Makes sense. Thanks for the explanation. http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h File src/kudu/rebalance/rebalance_algo.h: http://gerrit.cloudera.org:8080/#/c/24863/3/src/kudu/rebalance/rebalance_algo.h@201 PS3, Line 201: the equally skewed candidates question: Is 'prefer_follower_moves' effective only when there is a tie between equally skewed candidates? Or 'prefer_follower_moves' works independent of whether there there are equal skewed candidates or not? -- To view, visit http://gerrit.cloudera.org:8080/24863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a86f1345b3adad084813e1b61a4a38ef566d035 Gerrit-Change-Number: 24863 Gerrit-PatchSet: 3 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 23 Sep 2026 05:26:50 +0000 Gerrit-HasComments: Yes
