Adar Dembo has posted comments on this change. Change subject: Change flush defaults to encourage parallel IO and larger flushes ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3186/2/src/kudu/cfile/cfile_writer.cc File src/kudu/cfile/cfile_writer.cc: Line 48: // The default value is optimized for throughput in the case that There's a similar comment in block_manager.cc; could you update that too? I think block_coalesce_close=true is uninteresting given cfile_do_on_finish=flush, but I'll leave that to your judgment. http://gerrit.cloudera.org:8080/#/c/3186/2/src/kudu/tablet/tablet_peer_mm_ops.cc File src/kudu/tablet/tablet_peer_mm_ops.cc: Line 32: DEFINE_int32(flush_threshold_mb, 1000, Nit: 1024 (power of 2)? -- To view, visit http://gerrit.cloudera.org:8080/3186 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c70d9c76ed33bbfca5480e1d1f343c6dab36d3b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
