Will Berkeley has posted comments on this change. Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix ......................................................................
Patch Set 2: Code-Review-1 (1 comment) > (1 comment) http://gerrit.cloudera.org:8080/#/c/3304/2//COMMIT_MSG Commit Message: Line 12: Deltafiles expect to be able to decode an index key into a DeltaKey. > hmm, really? where's that code path? I would have guessed that delta and bl I think the errors I saw when I didn't except delta files came from GetFirstRowIndexInCurrentBlock, about L449 of deltafile.cc. It decodes the index entry into a delta key, but a shortened key isn't decodable into a DeltaKey. The bloom file thing is speculation on my part while I investigate...I also forgot to actually commit the changes for my second patch set. I'll post an updated set after I get some more sleep. -- To view, visit http://gerrit.cloudera.org:8080/3304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
