Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache ......................................................................
Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/2887/8/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 2516: LOG(WARNING) << "Not sending DeleteTablet requests; no consensus state for tablet " > is this warning-worthy? do you expect this to be common? No, I don't expect it to be common. Don't care strongly about the warning, will downgrade. Line 3011: locs_pb->set_deprecated_stale(false); > is this necessary? if the protobuf didn't specify a default, I think it's s But it's 'required' in the protobuf and has no default value, so doesn't that mean we must set it always and forever? -- To view, visit http://gerrit.cloudera.org:8080/2887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6376b5307f75f5d505b33a5ff4262da619cd1d8d Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
