Alexey Serbin has posted comments on this change. Change subject: Do not run (g)addr2line translator on MacOS X ......................................................................
Patch Set 1: (2 comments) > (2 comments) > > My understanding is that sanitizer-enabled Kudu builds on Mac OS > will report correct line numbers since they use LLVM's built-in > symbolizer, so translation is only actually missing on the > addresses emitted by a CHECK() or equivalent crash. Is this > correct? Thank you for review! I haven't tried to run sanitizer-enabled builds. Yes, as I understand the translation is needed for crash-related stacktrace printouts. Anyways, it seems safe to remove addr2line translator since it does no do much on MacOS X anyways, just takes some to run. http://gerrit.cloudera.org:8080/#/c/3360/1/build-support/run-test.sh File build-support/run-test.sh: PS1, Line 139: UNAME=$(uname -s) : if [ "$UNAME" = "Darwin" ]; then > How about using the bash built-in $OSTYPE? I think we typically use that in Done Line 143: # into line number. The atos utility is able to do that only if > Nit: can you fix this line's formatting a bit? Looks like you can squeeze a Sure -- actually, I found these lines were too long (more than 80 chars). I'll make them shorter and more uniformly filled. -- To view, visit http://gerrit.cloudera.org:8080/3360 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idf8a81ae7f2e1b938734a4b66bec82cb731d90cc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
