Will Berkeley has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix ......................................................................
Patch Set 6: > Sorry for the delay on this, Will. I was on PTO the last couple of > weeks. Hope to get back to review this week. I noticed the last > build failed but the build results have been purged by this point. > Is the current rev passing tests, etc? No worries Mr Lipcon. I hope you enjoyed your vacation. IIRC it passes everything, but on the last build Jenkins choked somehow and failed the build through no fault on my own. I'll verify it passes the basic stuff locally and repush so Jenkins can (hopefully) verify. Unrelatedly, I have a patch in the works for KUDU-1227 (update-merge). It works and passes the tests + the tests I wrote for it, but definitely needs some review love. Is there interest in that for 1.0? I mostly did it for personal enrichment but obv happy to contribute it if it's wanted. -- To view, visit http://gerrit.cloudera.org:8080/3304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I68ae9146fabd4a19b17d103d118d2d60e28bb315 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: No