Sarah Jelinek has posted comments on this change. Change subject: Persistent cache support for NVM ......................................................................
Patch Set 16: (1 comment) Pushed all code review changes. http://gerrit.cloudera.org:8080/#/c/2593/15/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: Line 54: TAG_FLAG(nvm_cache_path, experimental); > The reason for this is that when operating in persistent mode the user has I died modify this to be nvm_cache_pool to indicate that when persistent memory is in use a pool with a specified name is created. Otherwise it's just a directory where a pool is created. -- To view, visit http://gerrit.cloudera.org:8080/2593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id72570ead662670bf42175756a18ae08d7cd0a07 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sarah Jelinek <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sarah Jelinek <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
