David Ribeiro Alves has posted comments on this change. Change subject: WIP: Integration test for replay cache ......................................................................
Patch Set 9: (10 comments) http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/consensus/consensus_peers.cc File src/kudu/consensus/consensus_peers.cc: PS9, Line 57: DEFINE_double remove PS9, Line 237: MAYBE_FAULT remove http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: PS9, Line 1067: TEST_F add crashes and bootstraps to this test http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/result_tracker.cc: PS9, Line 108: ChangeDriver doc this better PS9, Line 116: ClientState add a find completion record or null Line 128: completion_record->ongoing_rpcs.push_back({nullptr, add a comment explaining this. http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/rpc/result_tracker.h File src/kudu/rpc/result_tracker.h: PS9, Line 63: The add info about the invariants PS9, Line 65: If add info about handlers and drivers, etc http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/tablet/transactions/transaction_driver.cc File src/kudu/tablet/transactions/transaction_driver.cc: PS9, Line 213: while doc this better http://gerrit.cloudera.org:8080/#/c/3519/9/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: PS9, Line 294: // remove -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
