Todd Lipcon has posted comments on this change.

Change subject: Add a fault injection point _after_ the leader sends a request
......................................................................


Patch Set 2:

(1 comment)

why not merge this commit with whatever uses it? not a fan of these commits 
with no accompanying coverage/usage

http://gerrit.cloudera.org:8080/#/c/3568/2/src/kudu/consensus/consensus_peers.cc
File src/kudu/consensus/consensus_peers.cc:

Line 57: DEFINE_double(fault_crash_after_leader_request_fraction, 0.0,
I think it's clearer to say "on leader response" rather than "after leader 
request"


-- 
To view, visit http://gerrit.cloudera.org:8080/3568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to