Todd Lipcon has submitted this change and it was merged. Change subject: Add a ToString() method to Proxy ......................................................................
Add a ToString() method to Proxy ReplicatedRpc takes the server proxy type as a template argument and uses its ToString() method to print out details in case of error. Usually this is RemoteTablet, which has a ToString() method, but that might not always be the case. In fact, in a test in a follow up patch ReplicatedRpc takes Proxy as the server proxy type and compilation would fail due to a missing ToString(). We could make ReplicatedRpc not use the ToString() method, but it seems very helpful to have it so this patch adds it to Proxy instead. Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Reviewed-on: http://gerrit.cloudera.org:8080/3502 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <t...@apache.org> --- M src/kudu/rpc/proxy.cc M src/kudu/rpc/proxy.h M src/kudu/rpc/rpc-test.cc 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
