Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Integrate with the replay cache ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java: PS1, Line 800: setCallSeqId > unrelated? Not at all, we now have 2 things called sequence ids: for RPCs and for Scanners. This is a place where I had to really specify which sequence id I was using. Related to that, I was thinking that we should not have two sequence ids in the code base. We could call one rpcSequenceId and the other scanSequenceId. http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java: PS1, Line 107: UNSET_SEQUENCE_ID > would be good to mimick the c++ client (NO_SEQ_NO iirc) Oh I didn't even look at the c++ client :P I'll change it. http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: PS1, Line 40: firstIncompleteRpc > mimick the c++ API (same method names) Done http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java: Line 253: requestIdBuilder.setAttemptNo(rpc.attempt); > these are guaranteed to be unique, right? Per RPC you mean? Yes, else there's a bug. http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java File java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java: Line 22: public class TestRequestTracker { > would be easier to mimick the c++ test exactly, that way we know the impls Makes sense. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
