Todd Lipcon has posted comments on this change. Change subject: rw_mutex: prevent recursive use ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3641/1/src/kudu/util/rw_mutex-test.cc File src/kudu/util/rw_mutex-test.cc: Line 52: // Multi-threaded test that tries to find deadlocks in the RWMutex wrapper. is this actually a realistic scenario to be concerned about? don't we expect pthread to work ok? Line 71: // Do something that the compiler won't optimize away. I dont think the compiler can optimize this stuff away because it includes library calls to pthread. also the volatile load can't be optimized out -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ae30ec123a16c39ef0c15ee2d2176f807df03db Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
