Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API ......................................................................
Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/6/CMakeLists.txt File CMakeLists.txt: Line 1000: # "make doxydocs" target Sorry to be a buzz kill, but can we just make this target "doxygen" instead of "doxydocs"? Line 1015: COMMAND make all install DESTDIR=${DOXY_CLIENT_DESTDIR} Can this be made to work with Ninja was well? I think you just need to replace make with ${CMAKE_MAKE_PROGRAM} http://gerrit.cloudera.org:8080/#/c/3619/6/docs/.gitignore File docs/.gitignore: Line 19 nit: spurious change http://gerrit.cloudera.org:8080/#/c/3619/6/src/kudu/client/client.h File src/kudu/client/client.h: Line 28: #include <cstdint> This change isn't required for this patch, is it? http://gerrit.cloudera.org:8080/#/c/3619/6/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: Line 262: if ! `which -s doxygen` && [ ! -d $DOXYGEN_DIR ]; then The -s command-line flag is not available on GNU systems. You can do: if ! which doxygen >/dev/null && [ ! -d "$DOXYGEN_DIR" ]; then -- To view, visit http://gerrit.cloudera.org:8080/3619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
