Todd Lipcon has posted comments on this change. Change subject: master: do not delete unknown tablets ......................................................................
Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3645/5//COMMIT_MSG Commit Message: Line 7: master: do not delete unknown tablets I wonder if we now need some tool to "reformat" a tablet server? or to insert a dummy "deleted table" or "deleted tablets" entry into the master? i.e what if for some reason we do end up with some unknown tablets that are being reported, and we want to delete them to reclaim the space. Right now we'd have to send manual delete_tablet RPCs to every server which sounds kind of complicated to script up. Another option would be some kind of "automatically resurrect the tablet based on reports" or something? (thinking about the case here where we have taken a backup of a master and roll back in time, for example). (of course feel free to backlog this, just curious if we anticipate a support burden here) Line 9: Quoting from the multi-master design doc: nit: can you provide a link or source code path here? http://gerrit.cloudera.org:8080/#/c/3645/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: PS5, Line 1546: INFO) WARNING might be more appropriate here? or perhaps INFO if it's an incremental report, and WARNING if it's a full report? (since the latter indicates a persistent condition whereas the former might be a transient issue as in the race described above?) -- To view, visit http://gerrit.cloudera.org:8080/3645 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
