Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java: Line 257: private final String clientId; > looks like this isn't used? Done http://gerrit.cloudera.org:8080/#/c/3631/5/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: Line 64: return incompleteRpcs.peek(); > peek will return null if the queue is empty, so you can get rid of the isEm Yeah it's just a question of timing, doing a peek then checking for null has the same issue, it might have already changed by the time you're checking... But your suggestion makes sense and saves a call! -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
