yiheng commented on a change in pull request #197: [LIVY-574][THRIFT SERVER][TEST] Add tests for metadata operations URL: https://github.com/apache/incubator-livy/pull/197#discussion_r313687551
########## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala ########## @@ -69,6 +69,51 @@ trait CommonThriftTests { } assert(!resultSetComplex.next()) } + + def getCatalogTest(connection: Connection): Unit = { + val metadata = connection.getMetaData + val catalogResultSet = metadata.getCatalogs() + assert(!catalogResultSet.next()) + } + + def getTableTypeTest(connection: Connection): Unit = { + val metadata = connection.getMetaData + val tableTypesResultSet = metadata.getTableTypes() + tableTypesResultSet.next() + assert(tableTypesResultSet.getString(1) == "TABLE") + tableTypesResultSet.next() + assert(tableTypesResultSet.getString(1) == "VIEW") + assert(!tableTypesResultSet.next()) + } + + def getTypeInforTest(connection: Connection): Unit = { + val metadata = connection.getMetaData + val typeInfoResultSet = metadata.getTypeInfo() + typeInfoResultSet.next() + assert(typeInfoResultSet.getString(1) == "void") + assert(typeInfoResultSet.getInt(2) == 0) + assert(typeInfoResultSet.getInt(3) == 0) + assert(typeInfoResultSet.getString(4) == null) + assert(typeInfoResultSet.getString(5) == null) + assert(typeInfoResultSet.getString(6) == null) + assert(typeInfoResultSet.getShort(7) == 1) + assert(typeInfoResultSet.getBoolean(8) == false) + assert(typeInfoResultSet.getShort(9) == 0) + assert(typeInfoResultSet.getBoolean(10) == true) + assert(typeInfoResultSet.getBoolean(11) == false) + assert(typeInfoResultSet.getBoolean(12) == false) + assert(typeInfoResultSet.getString(13) == null) + assert(typeInfoResultSet.getShort(14) == 0) + assert(typeInfoResultSet.getShort(15) == 0) + assert(typeInfoResultSet.getInt(16) == 0) + assert(typeInfoResultSet.getInt(17) == 0) + assert(typeInfoResultSet.getInt(18) == 0) + val LEFT_TYPE_NUM = 16 + for (i <- 1 to LEFT_TYPE_NUM) { + assert(typeInfoResultSet.next()) Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services