jerryshao commented on a change in pull request #201: [LIVY-639] add start time
and completion time and duration to the statements web ui
URL: https://github.com/apache/incubator-livy/pull/201#discussion_r315030442
##########
File path: rsc/src/main/java/org/apache/livy/rsc/driver/Statement.java
##########
@@ -56,4 +59,26 @@ public void updateProgress(double p) {
this.progress = p;
}
}
+
+ public void setDuration(String d) {
+ if (this.state.get().isOneOf(StatementState.Cancelled,
StatementState.Available)) {
+ this.duration = d;
+ }
+ }
+
+ public String getStarted() {
+ return started;
+ }
+
+ public void setStarted(String started) {
+ this.started = started;
+ }
+
+ public String getCompleted() {
+ return completed;
+ }
+
+ public void setCompleted(String completed) {
+ this.completed = completed;
+ }
Review comment:
As all the fields are public, it is not necessary to write all these
setter/getters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
