zjffdu commented on a change in pull request #235: [LIVY-666] Support named 
interpreter groups
URL: https://github.com/apache/incubator-livy/pull/235#discussion_r328892950
 
 

 ##########
 File path: 
repl/scala-2.11/src/main/scala/org/apache/livy/repl/SparkInterpreter.scala
 ##########
 @@ -133,3 +139,8 @@ class SparkInterpreter(protected override val conf: 
SparkConf) extends AbstractS
     }
   }
 }
+
+object SparkInterpreter {
+  var outputDir: File = null
 
 Review comment:
   Why outputDir is shared across InterpreterGroup ? Wouldn't it cause issues 
between multiple scala repl ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to