huianyi commented on a change in pull request #238: [LIVY-689] Deliver stage process message to the end user using thriftserver URL: https://github.com/apache/incubator-livy/pull/238#discussion_r333412835
########## File path: core/src/main/scala/org/apache/livy/OperationMessageManager.scala ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.livy + +object OperationMessageManager extends Logging{ + + def offer(message: Any): Unit = { + if (threadLocalLogQueue.get() != null){ + threadLocalLogQueue.get().offer(message.toString) + } + } + + def get(): ConcurrentBoundedLinkedQueue[String] = { + threadLocalLogQueue.get() + } + + def set(threadLocalLogQueue: ConcurrentBoundedLinkedQueue[String]){ + this.threadLocalLogQueue.set(threadLocalLogQueue) + } + private val threadLocalLogQueue = new ThreadLocal[ConcurrentBoundedLinkedQueue[String]] Review comment: I think this gives us another more convenient way to get operationMessage object in other classes if they are in the same thread(just like `Sessionstate.get()` method in hive), for those classes are not in the same thread, we need deliver this object to them, like Class `LivyExecuteStatementOperation`. Actually, if we do not use this threadLocal variable, for class `ClientProtocol` needing operationMessage to deliver process message, we should first deliver operationMessage to RSCClient, then RSCClient deliver it to ClientProtocol, which needs lots of set and get method. Would it be aIright if I add detailed comment in `OperationMessageManager` to call developers' attention to the constraint? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
